Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an executable property to the custom runners #45

Merged
merged 3 commits into from
Apr 4, 2024
Merged

add an executable property to the custom runners #45

merged 3 commits into from
Apr 4, 2024

Conversation

jonapich
Copy link
Member

@jonapich jonapich commented Apr 4, 2024 •
edited
Loading

Note to reviewers: The only code change is in coveo_stew/ci/any_runner.py (the first file in the PR). Everything else is noise from running ruff-format followed by black again 😅 I couldn't be bothered to revert the noise, I kinda like the end result.

This allows the same executable to be used for different purposes, e.g.:

[tool.stew.ci.custom-runners.ruff-lint]
executable = "ruff"
working-directory = "project"
check-args = ["check", "."]
autofix-args = [ "check", "--fix", "."]

[tool.stew.ci.custom-runners.ruff-format]
executable = "ruff"
working-directory = "project"
check-args = ["format", "--check", "."]
autofix-args = ["format", "."]

You can test this locally by installing coveo-stew=3.0.22a1

@jonapich jonapich marked this pull request as ready for review April 4, 2024 18:21
@jonapich jonapich requested review from a team, sysboy, dblanchette, mikebaum and spparadis and removed request for a team April 4, 2024 18:21
Base automatically changed from chore/bump-dependencies to main April 4, 2024 18:47
spparadis
spparadis approved these changes Apr 4, 2024
View reviewed changes
Copy link

@spparadis spparadis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the fast addition of the feature!

Not sure what is the release process, but maybe the README could mention this new custom config param as well!

@jonapich jonapich force-pushed the feature/custom-runner-duplicates branch from cd873cf to 5b58639 Compare April 4, 2024 18:56
@jonapich
Copy link
Member Author

jonapich commented Apr 4, 2024

Not sure what is the release process, but maybe the README could mention this new custom config param as well!

@spparadis Good call! Added!

@jonapich jonapich merged commit b5f7986 into main Apr 4, 2024
18 checks passed
@jonapich jonapich deleted the feature/custom-runner-duplicates branch April 4, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spparadis spparadis spparadis approved these changes

@sysboy sysboy Awaiting requested review from sysboy sysboy was automatically assigned from coveo/dev-tooling-reviewers-1

@dblanchette dblanchette Awaiting requested review from dblanchette dblanchette was automatically assigned from coveo/dev-tooling-reviewers-1

@mikebaum mikebaum Awaiting requested review from mikebaum mikebaum was automatically assigned from coveo/dev-tooling-reviewers-3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonapich @spparadis